Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] set Syphon executable version string on Windows #420

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

EdGeraghty
Copy link
Collaborator

This doesn't fix Flutter not passing versions, but at least versions the exe

Types

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which improves code quality - QA thoroughly )
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)

Changes

🔮 Features

🔒 Security

🛠 Performance

🐛 Fixes

Version the Windows executable

📐 Refactoring

Media (if applicable)

QA

  • Signup
  • Login
  • Logout
  • Unencrypted Chat
  • Encrypted Chat
  • Group Chats
  • Profile Changes
  • Theming Changes
  • Force Kill and Restart

Final Checklist

  • All associated issues have been linked to PR
  • All necessary changes made to the documentation
  • Parties interested in these changes have been notified

This doesn't fix Flutter not passing versions, but at least versions the exe
@ereio ereio merged commit e85eab1 into syphon-org:main Dec 6, 2021
@EdGeraghty EdGeraghty deleted the fix/windows-version-number branch December 6, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants